Remove unused properties from Resource in config doc#1497
Merged
SteveL-MSFT merged 3 commits intoPowerShell:mainfrom Apr 27, 2026
Merged
Remove unused properties from Resource in config doc#1497SteveL-MSFT merged 3 commits intoPowerShell:mainfrom
SteveL-MSFT merged 3 commits intoPowerShell:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the DSC configuration document model to move further away from ARM template compatibility by removing Resource properties that are no longer used / don’t apply to DSC.
Changes:
- Removed several ARM-oriented
Resourcefields from the config document schema/model (comments,location,tags,identity,sku,kind,scope,plan). - Updated export-to-configuration construction logic to no longer map exported
_kindinto the config documentResource. - Minor formatting cleanup in
check_security_contextconditional.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/dsc-lib/src/configure/mod.rs | Updates export-to-config logic; removes _kind handling and includes a minor formatting change. |
| lib/dsc-lib/src/configure/config_doc.rs | Removes unused/ARM-specific fields from the config document Resource struct and its constructor. |
michaeltlombardi
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
With the decision to move away from strict ARM template compat, removing some properties that aren't used and doesn't make sense for DSC